feat: add back site scripts#613
Merged
zastrowm merged 2 commits intostrands-agents:mainfrom Mar 8, 2026
Merged
Conversation
Add back the shortbread and websdk integration
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Assessment: Comment (Minor feedback)
Well-structured PR that cleanly integrates AWS Shortbread cookie consent and the WebSDK across both the docs pages and landing page. The code follows good practices with graceful degradation when Shortbread is unavailable.
Review Highlights
- Code Quality: Good error handling with try-catch blocks and appropriate console warnings for fallback scenarios
- Architecture: Clean separation with
SiteScripts.astrocomponent shared acrossHead.astroandLandingLayout.astro - Documentation: SITE-ARCHITECTURE.md properly updated to reflect the new components and their purposes
- Minor Fix: One docstring incorrectly references a non-existent
Footer.astrofile (see inline comment)
Clean implementation overall! 🎉
Contributor
Documentation Preview ReadyYour documentation preview has been successfully deployed! Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-cms-613/docs/user-guide/quickstart/overview/ Updated at: 2026-03-07T22:19:44.120Z |
dbschmigelski
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Strandsagents.com has Shortbread (cookie consent) and the WebSDK wired up; neither made it into this repo during the initial migration.
Shortbread is extracted into
SiteScripts.astroand included in both the StarlightHeadoverride (docs pages) andLandingLayout(landing page), since the landing page has its own<head>and bypasses Starlight's component pipeline entirely.The AWS legal footer (Privacy / Site Terms / Cookie Preferences) was also missing. Rather than constraining it inside Starlight's
ContentPanel, it's injected via aPageFrameoverride so it spans the full content width below the sidebar.Copyright.astrois shared between the docs footer and the landing page.Related Issues
#441
Type of Change
Checklist
mkdocs serveBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.