feat: auto-setup SDKs and data store before dev/build/test#614
Open
zastrowm wants to merge 3 commits intostrands-agents:mainfrom
Open
feat: auto-setup SDKs and data store before dev/build/test#614zastrowm wants to merge 3 commits intostrands-agents:mainfrom
zastrowm wants to merge 3 commits intostrands-agents:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Assessment: Comment
Good developer experience improvement that simplifies onboarding by automating SDK setup and data store population.
Review Categories
- Robustness: The global-setup process cleanup could be improved to handle process trees and early server crashes (see inline comments)
- Consistency: Code follows existing patterns in the repo (execSync usage, plugin structure)
- Documentation: PR description is clear; no public API changes so documentation PR is not required
The implementation is clean and achieves its goal. The inline suggestions are optional improvements for edge cases in CI environments.
Contributor
Documentation Preview ReadyYour documentation preview has been successfully deployed! Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-cms-614/docs/user-guide/quickstart/overview/ Updated at: 2026-03-07T22:18:29.770Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously,
npm run dev,npm run build, andnpm testall required manual pre-flightsteps that weren't obvious to someone new to the repo. This PR makes all three work
out of the box.
vite-plugin-sdk-setup.ts— Vite plugin that auto-runssdk:clone+sdk:generateat startup if the
.build/sdk-*artifacts are missing.test/global-setup.ts— vitest global setup that spins upastro devjust long enoughto populate the content layer data store if absent, working around this Astro 5 issue.
test:prepstep.Related Issues
#441
Type of Change
Checklist
mkdocs serveBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.