Open
Conversation
* remove aliases that are the same as primary command name
* remove pointless empty ("") aliases as they break bash completion
* align cmdutils.NewResourceCmd parameters in test_help.go to match
call parameters in its respective Command.
Signed-off-by: Robert Moucha <robert.moucha@gooddata.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Attempt to use built-in bash completion provided by cobra package fails on invalid shell expressions.
During investigation I noticed it is caused by declaring empty strings (
"") as command aliases. Fortunately, commandaliases are passed as variadic arguments so fix is very simple and doesn't require substantial changes.
Modifications
cmdutils.NewResourceCmdparameters intest_help.goto match call parameters in their respectiveCommandfunctions.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-docMy changes do not modify logic or public command-line interface.
doc(If this PR contains doc changes)