add delete schemas force option#1971
Open
Radiancebobo wants to merge 1 commit intostreamnative:masterfrom
Open
add delete schemas force option#1971Radiancebobo wants to merge 1 commit intostreamnative:masterfrom
Radiancebobo wants to merge 1 commit intostreamnative:masterfrom
Conversation
Author
|
@mattisonchao @nlu90 @zymap Please review the code for me, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently,
pulsarctllacks the ability to force delete a schema. If a schema's underlying ledger cannot be opened or is in a corrupted state, the standard delete command fails.In such scenarios, users are currently forced to switch to the Java-based
pulsar-admintool (which supportspulsar-admin schemas delete xxx -f) to clean up these schemas.This PR adds the
--forceflag topulsarctl schemas deleteto support forced deletion, resolving these edge cases and bringing feature parity with the Javapulsar-adminCLI.Modifications
--forceflag in theschemas deletecommand.Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
--forceallows deleting schemas that otherwise fail to delete due to ledger issues.Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(This aligns the CLI behavior with the existing Admin API capabilities and standard flags)
doc(If this PR contains doc changes)