Skip to content

Feat: Swift Testing framework (2/3)#23

Merged
DanielCech merged 19 commits intomasterfrom
feat/swift-testing
Mar 6, 2026
Merged

Feat: Swift Testing framework (2/3)#23
DanielCech merged 19 commits intomasterfrom
feat/swift-testing

Conversation

@DanielCech
Copy link
Copy Markdown
Member

@DanielCech DanielCech commented Jan 13, 2026

  • The dependency injection tests are converted to the new Testing library
  • Tests are adapted to the parameters packs approach. There is also one test for checking the maximum allowed argument count.
  • I removed the default scope functionality because it caused some ambiguity in parameter type inference. We need to be specific about the scope, which is, imho, a good thing.
  • I tested this branch (including multiple argument propagation) on TechnoAlpin in the dc/feat/new-di-test branch

This PR is built on top of #22

Copy link
Copy Markdown
Contributor

@cejanen cejanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Testing would be nice if we utilize features to better structure tests (suite, test domain etc)

# Conflicts:
#	Tests/Container/Async/AsyncArgumentTests.swift
#	Tests/Container/Sync/ArgumentTests.swift
@DanielCech DanielCech requested a review from cejanen January 15, 2026 13:52
@DanielCech
Copy link
Copy Markdown
Member Author

@cejanen I updated the tests from #22 and improved the structure - tests are organized into suites and use tags.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 19, 2026

1 Warning
⚠️ Big PR - you should create smaller!

Generated by 🚫 Danger

@DanielCech DanielCech changed the title Feat: Swift Testing framework Feat: Swift Testing framework (3/4) Feb 4, 2026
@DanielCech DanielCech changed the title Feat: Swift Testing framework (3/4) Feat: Swift Testing framework (2/3) Feb 9, 2026
# Conflicts:
#	CHANGELOG.md
#	Tests/Container/Async/AsyncArgumentTests.swift
#	Tests/Container/Async/AsyncBaseTests.swift
#	Tests/Container/Async/AsyncComplexTests.swift
#	Tests/Container/Sync/ArgumentTests.swift
#	Tests/Container/Sync/AutoregistrationWithArgumentTest.swift
#	Tests/Container/Sync/BaseTests.swift
#	Tests/Container/Sync/ComplexTests.swift
# Conflicts:
#	Tests/Container/Async/AsyncArgumentTests.swift
#	Tests/Container/Async/AsyncComplexTests.swift
#	Tests/Container/Sync/ArgumentTests.swift
#	Tests/Container/Sync/AutoregistrationWithArgumentTest.swift
#	Tests/Container/Sync/ComplexTests.swift
Comment thread Tests/Container/Async/AsyncBaseTests.swift Outdated
@DanielCech DanielCech requested a review from TParizek February 20, 2026 10:37
Copy link
Copy Markdown
Contributor

@TParizek TParizek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks great now 👍 Please just remove the one commented out test case and let's wait for CI to be available, so we can check changes - it should be available very soon.

Comment thread Tests/Container/Sync/BaseTests.swift Outdated
@DanielCech DanielCech requested a review from TParizek February 24, 2026 13:01
TParizek
TParizek previously approved these changes Mar 5, 2026
Base automatically changed from feat/multiple-arguments to master March 6, 2026 12:12
@DanielCech DanielCech dismissed TParizek’s stale review March 6, 2026 12:12

The base branch was changed.

@DanielCech DanielCech merged commit 7756ea8 into master Mar 6, 2026
2 checks passed
@DanielCech DanielCech deleted the feat/swift-testing branch March 6, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants