fix: return undefined from getPrefix/parseId for non-string input - #13
Open
shaurya703 wants to merge 1 commit into
Open
fix: return undefined from getPrefix/parseId for non-string input#13shaurya703 wants to merge 1 commit into
shaurya703 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getPrefix()andparseId()crashed withTypeError: Cannot read properties of null (reading 'indexOf')when handed non-string input, whileisId()andgetTimestamp()already tolerated it. This made half the read-side API unsafe for untrusted values from request bodies, query strings, and databases — especially in plain JavaScript where there is no compiler to catch the mismatch.Changes
typeof value !== "string"guard returningundefinedat the top of bothgetPrefixandparseIdinsrc/utils/validate.ts, matching the existingisId/getTimestampbehaviour.test/validate.test.tscoveringnull,undefined, numbers, and objects for both functions.Unreleased.Verification
npm run format,npm run typecheck,npm test(108 passing),npm run build, andnpm run smokeall pass.Fixes #10