fix: handle concurrent OTP signup email unique race - #2686
Open
rohanpatel2002 wants to merge 1 commit into
Open
Conversation
Detect users_email_partial_key conflicts during signup and retry once on the existing-user path so /otp returns 200 instead of a raw 500. Fixes supabase#2675
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Concurrent
POST /otpfor the same new email can hitusers_email_partial_keyand return a raw 500 (unexpected_failure/ aborted transaction).Fixes #2675
What is the new behavior?
Unique email conflicts during signup are detected and retried once on the existing-user path, so the losing request returns 200 like a normal retry.
Additional context
Shared fix in
signupNewUser/Signup(covers MagicLink OTP and direct signup). Includes a concurrent OTP regression test.