fix(web3): always bind SIWE/SIWS Domain to URI host - #2687
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
Domain matching was skipped when URI.Hostname() was localhost, so a message with Domain=attacker.example and URI=http://localhost:5173/ could pass URI allowlist checks and skip domain bind. Require URI.Host == Domain for all hosts; keep the existing https Domain allowlist check for non-localhost.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Domain matching for Web3 SIWE/SIWS grants was skipped when
URI.Hostname() == "localhost". That let a signed message withDomain=attacker.exampleand an allowlistedURI=http://localhost:5173/skip the domain bind while still passing the URI allowlist.This change always requires
URI.Host == Domain. The existinghttps://{Domain}/allowlist check remains for non-localhost hosts so legitimate localhost happy-path fixtures keep working.Test plan
invalid_grant(domain bind)Domain/URIstill succeed in full suiteMade with Cursor