Fix expired SIWE message acceptance without Not Before - #2698
Open
depthfirst-app[bot] wants to merge 1 commit into
Open
Conversation
![depthfirst-app[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability
Ethereum Web3 login incorrectly conditioned expiration validation on the presence of the optional SIWE
Not Beforefield.Impact
A captured, valid signature for a message without
Not Beforecould be replayed after itsExpiration Timeto mint authentication tokens.Solution
Validate
Expiration Timewhenever it is present and non-zero, regardless of whetherNot Beforewas supplied. The regression test now covers an expired signed Ethereum message withoutNot Beforeand confirms it is rejected as an invalid grant.Tested with:
go test ./internal/api -run 'TestWeb3/TestValidationRules_Expired$' -count=1🔍 View Vulnerability Details: Code Vulnerability