perf: add ETS cache to list/1 and reduce diff processing reductions#28
Open
filipecabaco wants to merge 1 commit into
Open
perf: add ETS cache to list/1 and reduce diff processing reductions#28filipecabaco wants to merge 1 commit into
filipecabaco wants to merge 1 commit into
Conversation
Adds an ETS cache to list/1 to avoid hitting the Tracker GenServer when N channel processes read presence state concurrently. The cache is lazily populated on first access per topic and kept warm by diffs. Benchmarks show 1.8–2.1x faster median and 3–4x better 99th percentile under 100 concurrent callers. Also removes the redundant Enum.reverse from group/1 (called twice per topic per diff cycle), saving 7–15% scheduler reductions at production scale.
40ed469 to
bcc4e64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds an ETS cache to list/1 to avoid hitting the Tracker GenServer when N channel processes read presence state concurrently. The cache is lazily populated on first access per topic and kept warm by diffs. Benchmarks show 1.8–2.1x faster median and 3–4x better 99th percentile under 100 concurrent callers.
Also removes the redundant Enum.reverse from group/1 (called twice per topic per diff cycle), saving 7–15% scheduler reductions at production scale.