Skip to content

fix: correctly categorize errors related to saturated project databases#1106

Merged
itslenny merged 3 commits into
masterfrom
lenny/handle-429-errors-more-better
May 13, 2026
Merged

fix: correctly categorize errors related to saturated project databases#1106
itslenny merged 3 commits into
masterfrom
lenny/handle-429-errors-more-better

Conversation

@itslenny
Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

These errors caused by projects under extreme load throw as 500 errors

  • 'server login has been failing, cached error: connect timeout (server_login_retry)',
  • 'server login has been failing, cached error: the database system is not accepting connections (server_login_retry)',

This previous change miscategorized no more connections allowed as a 503. Without this it is correctly handled in error-hanler.ts as a 429

What is the new behavior?

Errors related to project databases being overloaded throw as 429 slow down

@itslenny itslenny requested a review from a team as a code owner May 13, 2026 17:03
@coveralls
Copy link
Copy Markdown

coveralls commented May 13, 2026

Coverage Report for CI Build 25825624299

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.04%) to 75.091%

Details

  • Coverage increased (+0.04%) from the base build.
  • Patch coverage: 4 of 4 lines across 3 files are fully covered (100%).
  • 3 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

3 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
src/http/error-handler.ts 1 79.59%
src/http/routes/s3/error-handler.ts 1 41.67%
src/internal/database/connection.ts 1 64.76%

Coverage Stats

Coverage Status
Relevant Lines: 10308
Covered Lines: 8165
Line Coverage: 79.21%
Relevant Branches: 5947
Covered Branches: 4041
Branch Coverage: 67.95%
Branches in Coverage %: Yes
Coverage Strength: 413.58 hits per line

💛 - Coveralls

Comment thread src/http/error-handler.ts Outdated
@itslenny itslenny enabled auto-merge (squash) May 13, 2026 20:49
@itslenny itslenny merged commit a1c63fd into master May 13, 2026
13 of 14 checks passed
@itslenny itslenny deleted the lenny/handle-429-errors-more-better branch May 13, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants