Skip to content

fix: improve database error messages #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itslenny merged 1 commit into from
May 15, 2026
+18 −8
Merged

fix: improve database error messages #1107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/internal/errors/codes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { IcebergError } from '@storage/protocols/iceberg/catalog/errors'
import { DatabaseError } from 'pg'
import { StorageBackendError } from './storage-error'

export enum ErrorCode {
Expand Down Expand Up @@ -401,13 +402,20 @@ export const ERRORS = {
originalError: e,
}),

DatabaseSchemaMismatch: (e?: Error) =>
new StorageBackendError({
code: ErrorCode.DatabaseSchemaMismatch,
httpStatusCode: 503,
message: 'The database schema is out of sync. Please run migrations or contact support.',
originalError: e,
}),
DatabaseSchemaMismatch: (e: DatabaseError) =>
e.internalQuery && e.internalPosition // originates in trigger or RLS
? new StorageBackendError({
code: ErrorCode.DatabaseSchemaMismatch,
httpStatusCode: 503,
message: 'There is a database schema mismatch in a trigger or RLS policy: ' + e.where,
originalError: e,
})
: new StorageBackendError({
code: ErrorCode.DatabaseSchemaMismatch,
httpStatusCode: 503,
message: 'The database schema is out of sync. Please run migrations or contact support.',
originalError: e,
}),

ResourceLocked: (e?: Error) =>
new StorageBackendError({
Expand Down
4 changes: 3 additions & 1 deletion src/storage/database/knex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,7 +1145,9 @@ export class DBError extends StorageBackendError implements RenderableError {
switch (pgError.code) {
case '42501':
return ERRORS.AccessDenied(
'new row violates row-level security policy',
pgError.message.includes('row-level security')
? 'new row violates row-level security policy'
Comment thread
ferhatelmas marked this conversation as resolved.
: pgError.message,
pgError
).withMetadata({
query,
Expand Down