test(gotrue): give the list-users fixture a created_at - #1686
Merged
Conversation
User.fromJson requires created_at since timestamps became DateTime, and the mock response only carried an id, so every test in the file threw.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe admin list-users test mock now includes a fixed ChangesAdmin list-users test
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Tr00d
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Test fix.
What is the current behavior?
mainis red. Every test inpackages/gotrue/test/admin_list_users_test.dartthrows:#1663 made
User.createdAta non-nullableDateTimeparsed withparseIso8601, which throws when the field is absent. The mock list-users response in that file only carries anid, solistUsers()fails to parse the page before any of the pagination assertions run. It fails on all three Dart channels, see run 31509351637.What is the new behavior?
The fixture user has a
created_at, which is what the GoTrue server always sends for a user. The five tests in the file pass again, and the rest of the gotrue suite is unaffected.Summary by CodeRabbit