Conversation
🦋 Changeset detectedLatest commit: 1538989 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
manuel3108
left a comment
There was a problem hiding this comment.
What is flat standing for? What about just text instead? I had to look at your comment in packages/sv/lib/core/tooling/flat.ts to understand where flat is coming from.
As for the addon itself I would suggest that we create two questions / options. Based on the question Which demo would you like to include? i tried selecting nothing, which is understandably prohibited. I think we should ask the following two questions to not make it too complicated: Which providers do you want to set up? (credentials/github) & Do you want to include a demo? (yes/no) (Wording should be aligned with different addons)
Otherwise I think this is basically perfect and seems to work as expected. even the github oauth. Great work!
No description provided.