Skip to content

feat(add): better-auth#898

Merged
jycouet merged 42 commits intomainfrom
feat/better-auth
Feb 6, 2026
Merged

feat(add): better-auth#898
jycouet merged 42 commits intomainfrom
feat/better-auth

Conversation

@jycouet
Copy link
Contributor

@jycouet jycouet commented Jan 27, 2026

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2026

🦋 Changeset detected

Latest commit: 1538989

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 27, 2026

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@898
npx https://pkg.pr.new/sveltejs/cli/sv@898

commit: 1538989

@jycouet jycouet marked this pull request as ready for review January 27, 2026 23:54
Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is flat standing for? What about just text instead? I had to look at your comment in packages/sv/lib/core/tooling/flat.ts to understand where flat is coming from.

As for the addon itself I would suggest that we create two questions / options. Based on the question Which demo would you like to include? i tried selecting nothing, which is understandably prohibited. I think we should ask the following two questions to not make it too complicated: Which providers do you want to set up? (credentials/github) & Do you want to include a demo? (yes/no) (Wording should be aligned with different addons)

Otherwise I think this is basically perfect and seems to work as expected. even the github oauth. Great work!

@jycouet jycouet merged commit fd9e6a8 into main Feb 6, 2026
8 checks passed
@jycouet jycouet deleted the feat/better-auth branch February 6, 2026 08:46
@github-actions github-actions bot mentioned this pull request Feb 6, 2026
@sacrosanctic sacrosanctic mentioned this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants