feat: update SBOM external reference type for source code URLs from `…#233
Open
tngraf wants to merge 1 commit into
Open
feat: update SBOM external reference type for source code URLs from `…#233tngraf wants to merge 1 commit into
tngraf wants to merge 1 commit into
Conversation
…distribution` to `source-distribution`
gernot-h
reviewed
Jul 10, 2026
| component, | ||
| ExternalReferenceType.DISTRIBUTION, | ||
| CaPyCliBom.SOURCE_URL_COMMENT) | ||
| ExternalReferenceType.SOURCE_DISTRIBUTION, "") |
Collaborator
There was a problem hiding this comment.
Should we perhaps make this backward-compatible in central places when consuming an SBOM, probably users still have old (custom) scanners in use?
Collaborator
There was a problem hiding this comment.
I think there's get_ext_ref_source_url() for backward-compatible parsing, can we just call it here?
Collaborator
|
Just cosmetics, I think it would be better if we would use None instead of "" for the |
Collaborator
|
Apart from the comments above, the PR looks good, but I didn't test it yet, let me know if I should give it a try! |
gernot-h
requested changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update SBOM external reference type for source code URLs from
distributionto
source-distribution.