Skip to content

Conversation

@vpelikh
Copy link

@vpelikh vpelikh commented Jan 1, 2026

Description

This PR consists of two commits:

  • update to java 17 (minimum version for jackson 3)
  • update to jackson 3

Fixes: #4991

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor (non-breaking change)
  • 🧪 Tests
  • 📝 Documentation
  • 🧹 Chore (build or tooling)

Checklist

  • I have added/updated tests as needed
  • I have added/updated documentation where applicable
  • The PR title is descriptive
  • The code builds and passes tests locally
  • I have linked related issues (if any)

Screenshots / Additional Context

@vpelikh vpelikh force-pushed the update-to-java-17 branch from 7633f49 to 7b93974 Compare January 1, 2026 13:48
@vpelikh vpelikh changed the title feat: migrate to java 17 feat: migrate to jackson 3 Jan 3, 2026
@cbot59
Copy link

cbot59 commented Jan 4, 2026

I think we need to introduce constructor for ModelResolver(JsonMapper) and deprecate the old constructor so the newer release requires user to Jackson3 instead.

currently I have such usage on ModelResolver when using springdoc-openapi
Screenshot 2026-01-04 at 10 17 11

my first attempt to migrate to Jackson3 would be

public ModelResolver modelResolver(JsonMapper jsonMapper) {
        return new ModelResolver(jsonMapper);
    }

as it is more straightforward

changes:
- update maven-compiler-plugin to latest 3.14.1
- update maven-javadoc-plugin to latest 3.12.0
- update jacoco-maven-plugin to latest 0.8.14
- set maven.compiler.release to 17
- set source to 17 and update link to javadoc for maven-javadoc-plugin configuration
- set java-version to 17 in github workflows
- set java version to 17 in swagger-gradle-plugin
@vpelikh vpelikh force-pushed the update-to-java-17 branch from 0de7198 to f60ee1e Compare January 4, 2026 13:36
@vpelikh
Copy link
Author

vpelikh commented Jan 4, 2026

I have removed many of the changes associated with java 17, so the PR is now much smaller.

@cbot59, thanks for the comment! JsonMapper is a descendant of ObjectMapper, so return new ModelResolver(jsonMapper); should work without a new constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support Jackson 3.x release line

2 participants