Skip to content

ci: stop building for Android in a container#574

Open
finagolfin wants to merge 2 commits intoswiftlang:mainfrom
finagolfin:droid
Open

ci: stop building for Android in a container#574
finagolfin wants to merge 2 commits intoswiftlang:mainfrom
finagolfin:droid

Conversation

@finagolfin
Copy link
Member

This will fix the recent break because I updated the official SDK workflow script, as we only run that one on the GitHub runner directly, and stop downloading the NDK on every run.

I've also greatly broadened out the testing matrix, as all these other options should work too. We can trim them back down, if wanted, after trying a run.

@finagolfin
Copy link
Member Author

@madsodgaard, the latest Feb. 24 trunk snapshot SDK is failing, seemingly in the Java build step, whereas the new 6.3 snapshot builds I'm adding in this pull all passed. Any idea what's going on?

@finagolfin
Copy link
Member Author

Maybe this line?

Error executing swiftc -print-target-info

I see it in multiple jobs with trunk, but not 6.3. 🤨

@ktoso
Copy link
Collaborator

ktoso commented Feb 27, 2026

I'll see what I can find out here but cannot today sadly. Thank you for the PR!

@finagolfin
Copy link
Member Author

OK, rolling back to the container got the Android build working again, so I think I know what the problem is. Using a container like this works but is wasteful, as you're installing a container with the latest trunk snapshot toolchain pre-installed, then downloading the NDK and latest trunk snapshot toolchain again on every CI run. I think the reason that works though is that the pre-installed toolchain is added to the PATH, whereas the one downloaded by the upstream script is not, but invoking swiftc directly from the PATH is apparently required by your plugin.

I'll try modifying the upstream script after downloading it in the CI here, so that it also adds the toolchain it downloads to the PATH: that should finally fix running in the GitHub runner with no container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants