Escape generated JNI for @JavaImplementation methods#575
Open
colemancda wants to merge 2 commits intoswiftlang:mainfrom
Open
Escape generated JNI for @JavaImplementation methods#575colemancda wants to merge 2 commits intoswiftlang:mainfrom
@JavaImplementation methods#575colemancda wants to merge 2 commits intoswiftlang:mainfrom
Conversation
ktoso
reviewed
Feb 27, 2026
|
|
||
| // JNI identifier escaping per the JNI specification: | ||
| // https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/design.html#resolving_native_method_names | ||
| private extension String { |
Collaborator
There was a problem hiding this comment.
Suggested change
| private extension String { | |
| extension String { |
Collaborator
There was a problem hiding this comment.
This is to resolve the CI failure, we put access control on members, not extensions
ktoso
reviewed
Feb 27, 2026
| /// - `;` → `_2` | ||
| /// - `[` → `_3` | ||
| /// - Non-ASCII → `_0XXXX` (UTF-16 hex) | ||
| var escapedJNIIdentifier: String { |
Collaborator
There was a problem hiding this comment.
Suggested change
| var escapedJNIIdentifier: String { | |
| private var escapedJNIIdentifier: String { |
ktoso
reviewed
Feb 27, 2026
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Looks good, thanks for linking the relevant JNI docs
Needs to get the CI failure fixed, sadly didn't grant me maintainer edit rights so wasn't able to apply myself :)
ktoso
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix generated JNI for
@JavaImplementationmethods by escaping underscores and other characters correctly.