add AndroidCoreLibraryDesugaring trait#578
Open
madsodgaard wants to merge 1 commit intoswiftlang:mainfrom
Open
add AndroidCoreLibraryDesugaring trait#578madsodgaard wants to merge 1 commit intoswiftlang:mainfrom
AndroidCoreLibraryDesugaring trait#578madsodgaard wants to merge 1 commit intoswiftlang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API 23 runtime checks we were doing for desugaring class name happens at compile time, where I thought they were at runtime. So, that means even on API 24 (where
Optionalwas added`). The core library desugaring still uses the new class name.So instead we introduce a trait
AndroidCoreLibraryDesugaring, which will then enable this behaviour at compile time instead.