Skip to content

Fix typo: rename BridgeJSInstrincics to BridgeJSIntrinsics #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxDesiatov merged 6 commits into from
Jan 7, 2026
Merged

Fix typo: rename BridgeJSInstrincics to BridgeJSIntrinsics #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
319e6bc
Fix typo: rename `BridgeJSInstrincics` to `BridgeJSIntrinsic`
MaxDesiatov Jan 7, 2026
2a165e2
Rename`BridgeJSIntrincics.h`
MaxDesiatov Jan 7, 2026
e86974d
Fix typo in modulemap header filename
MaxDesiatov Jan 7, 2026
de00720
Fix typo in documentation comment for IntrinsicJSFragment
MaxDesiatov Jan 7, 2026
d2e0188
Rename BridgeJSIntrinsic.swift to BridgeJSIntrinsics.swift
MaxDesiatov Jan 7, 2026
220b156
Fix typo in BridgeJSIntrinsics reference
MaxDesiatov Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ These changes require updating the pre-generated Swift bindings committed to the

**Adding new BridgeJS intrinsics:**

If you add new `@_extern(wasm, module: "bjs")` functions to [`BridgeJSInstrincics.swift`](Sources/JavaScriptKit/BridgeJSInstrincics.swift), also add corresponding stub entries to [`Plugins/PackageToJS/Templates/instantiate.js`](Plugins/PackageToJS/Templates/instantiate.js) in the `importObject["bjs"]` object. This allows packages without BridgeJS-generated code to instantiate successfully.
If you add new `@_extern(wasm, module: "bjs")` functions to [`BridgeJSIntrinsics.swift`](Sources/JavaScriptKit/BridgeJSIntrinsics.swift), also add corresponding stub entries to [`Plugins/PackageToJS/Templates/instantiate.js`](Plugins/PackageToJS/Templates/instantiate.js) in the `importObject["bjs"]` object. This allows packages without BridgeJS-generated code to instantiate successfully.

## Support
If you have any questions or need assistance, feel free to reach out via [GitHub Issues](https://github.com/swiftwasm/JavaScriptKit/issues) or [Discord](https://discord.gg/ashJW8T8yp).
2 changes: 1 addition & 1 deletion Plugins/BridgeJS/Sources/BridgeJSLink/JSGlueGen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ final class JSGlueVariableScope {

/// A fragment of JS code used to convert a value between Swift and JS.
///
/// See `BridgeJSInstrincics.swift` in the main JavaScriptKit module for Swift side lowering/lifting implementation.
/// See `BridgeJSIntrinsics.swift` in the main JavaScriptKit module for Swift side lowering/lifting implementation.
struct IntrinsicJSFragment: Sendable {
/// The names of the parameters that the fragment expects.
let parameters: [String]
Expand Down
0 ...s/JavaScriptKit/BridgeJSInstrincics.swift → ...es/JavaScriptKit/BridgeJSIntrinsics.swift
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...vaScriptKit/include/BridgeJSInstrincics.h → ...avaScriptKit/include/BridgeJSIntrinsics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#ifndef _CJavaScriptKit_BridgeJSInstrincics_h
#define _CJavaScriptKit_BridgeJSInstrincics_h
#ifndef _CJavaScriptKit_BridgeJSIntrinsics_h
#define _CJavaScriptKit_BridgeJSIntrinsics_h

#include <stdint.h>
#include "WasmGlobalMacros.h"
Expand Down
2 changes: 1 addition & 1 deletion Sources/_CJavaScriptKit/include/module.modulemap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module _CJavaScriptKit {
header "_CJavaScriptKit.h"
header "BridgeJSInstrincics.h"
header "BridgeJSIntrinsics.h"
export *
}