Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Jan 14, 2026

Note

Stacked PR targeting:

Merge #603 first, then this PR will auto-retarget to master.

Description

This PR (excluding i18n changes in #603):

  1. Adds dynamic boost fee time confirmation estimates
  2. Implements weather widget API response caching
  3. Fixes WalletRepo state management by replacing uiState with individual repo states
  4. Cleans up deprecated code, warnings, and TODOs across the codebase
  5. Fixes all errors to use class instead of data class or data object
  6. Adds context to logs where it was missing
  7. Refactors most try/catch statements to runCatching
  8. Restructures Env constants
  9. Replaces combined main uiState with direct use of the separated node & wallet state
  10. Simplifies LightningService by removing redundant state management
  11. Removes deprecated migration test
  12. Remove completed TODOs and fixes or suppresses remaining ones
  13. Updates AGP & adds compose-stability-analyzer plugin
  14. Fixes or suppress all lint warnings
  15. Updates README and documentation adding recommended IDE plugins with setup guide
  16. Captures and cancels job for running the LDK event listener(s)
  17. Fixes toast blur on wallet restore error screen
  18. Removes logs reset on wallet wipe (now only for debug builds)

Preview

N/A

QA Notes

1. Boost Fee Estimates

  • Open a pending on-chain transaction
  • Tap boost/accelerate
  • Verify fee slider shows dynamic time estimates (e.g., "~10 min", "~30 min")

2. Weather Widget

  • Enable weather widget
  • Observe API calls are cached (check logs)
  • Widget should still update but without excessive network requests

3. Regression Testing

  • Verify wallet balance displays correctly
  • Test sending and receiving Lightning payments
  • Confirm background notifications work as expected

🤖 Generated with Claude Code

@ovitrif ovitrif changed the title chore: fix all warnings and code cleanup fix: compiler warnings and code patterns Jan 14, 2026
package to.bitkit.ui

import android.Manifest
import android.Manifest.*

Check warning

Code scanning / detekt

Detects wildcard imports Warning

Wildcard import
package to.bitkit.ui

import android.Manifest
import android.Manifest.*

Check warning

Code scanning / detekt

Wildcard imports should be replaced with imports using fully qualified class names. Wildcard imports can lead to naming conflicts. A library update can introduce naming clashes with your classes which results in compilation errors. Warning

android.Manifest.* is a wildcard import. Replace it with fully qualified imports.
@claude

This comment has been minimized.

@ovitrif ovitrif self-assigned this Jan 14, 2026
@claude

This comment has been minimized.

@claude

This comment has been minimized.

@claude

This comment has been minimized.

@claude

This comment has been minimized.

@claude

This comment has been minimized.

@claude

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants