httpd: extract VarlinkFramer helper to simplify forward loop - #82
Open
mvo5 wants to merge 2 commits into
Open
Conversation
When we do the websocket<->unix socket forwarding the loop was relatively complicated. It mixed I/O and protocol logic. This commit got inspired by the sans-io pattern and refactors so that the protocol logic is now split out from the I/O. This means that the code is simpler and easier to test. The logic about the Varlink protocol frames is now a new VarlinkFramer helper.
The websocket data handling had a (slightly) ugly "other" arm that was hiding `Message::Ping(_) | Message::Pong(_)` messages that can come via a websocket. This commit adds it for completeness so that its clear from looking at the match how each message type is handled.
daandemeyer
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we do the websocket<->unix socket forwarding the loop was relatively complicated. It mixed I/O and protocol logic. This commit got inspired by the sans-io pattern and refactors so that the protocol logic is now split out from the I/O. This means that the code is simpler and easier to test.
The logic about the Varlink protocol frames is now a new VarlinkFramer helper.
httpd: make the websocket message handling arm exhaustive
The websocket data handling had a (slightly) ugly "other" arm
that was hiding
Message::Ping(_) | Message::Pong(_)messagesthat can come via a websocket.