auth: pass AuthRequest to Authenticator::check_request and channel-binding newtype - #87
Open
mvo5 wants to merge 2 commits into
Open
auth: pass AuthRequest to Authenticator::check_request and channel-binding newtype#87mvo5 wants to merge 2 commits into
mvo5 wants to merge 2 commits into
Conversation
The RFC 9266 channel binding so far was just a string. This is not ideal as its not self-documenting and also not type safe (it should be impossible to pass it into the wrong place, this is not python afterall). So this commit uses the newtype pattern to simply make it a proper type to ensure the issues above are fixed.
This commit replaces positional check_request() parameters with a single struct carrying the raw headers. Auth methods now extract what they need themselves so adding a new auth method no longer changes the trait for the existing ones. This will be useful for jwt-auth and api-keys-auth.
This was referenced Jul 31, 2026
daandemeyer
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auth: pass AuthRequest to Authenticator::check_request
This commit replaces positional check_request() parameters with a
single struct carrying the raw headers. Auth methods now extract what
they need themselves so adding a new auth method no longer changes the
trait for the existing ones.
This will be useful for jwt-auth and api-keys-auth.
The RFC 9266 channel binding so far was just a string. This is not ideal as its not self-documenting and also not type safe (it should be impossible to pass it into the wrong place, this is not python afterall).
So this commit uses the newtype pattern to simply make it a proper type to ensure the issues above are fixed.