Fix #597: Pop namespace scope after NsReader::read_to_end#598
Draft
Mingun wants to merge 2 commits intotafia:masterfrom
Draft
Fix #597: Pop namespace scope after NsReader::read_to_end#598Mingun wants to merge 2 commits intotafia:masterfrom
Mingun wants to merge 2 commits intotafia:masterfrom
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #598 +/- ##
==========================================
+ Coverage 64.38% 64.47% +0.08%
==========================================
Files 35 35
Lines 16676 16676
==========================================
+ Hits 10737 10752 +15
+ Misses 5939 5924 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
failures (25):
ns_reader.rs (24):
reader::ns_reader::read_text::cdata
reader::ns_reader::read_text::comment
reader::ns_reader::read_text::decl
reader::ns_reader::read_text::doctype
reader::ns_reader::read_text::empty
reader::ns_reader::read_text::pi
reader::ns_reader::read_text::start
reader::ns_reader::read_text::text
reader::ns_reader::read_to_end::cdata
reader::ns_reader::read_to_end::comment
reader::ns_reader::read_to_end::decl
reader::ns_reader::read_to_end::doctype
reader::ns_reader::read_to_end::empty
reader::ns_reader::read_to_end::pi
reader::ns_reader::read_to_end::start
reader::ns_reader::read_to_end::text
reader::ns_reader::read_to_end_into::cdata
reader::ns_reader::read_to_end_into::comment
reader::ns_reader::read_to_end_into::decl
reader::ns_reader::read_to_end_into::doctype
reader::ns_reader::read_to_end_into::empty
reader::ns_reader::read_to_end_into::pi
reader::ns_reader::read_to_end_into::start
reader::ns_reader::read_to_end_into::text
issues.rs (1)
issue597
… and read_text
failures (4):
reader::ns_reader::read_text::start
reader::ns_reader::read_text::text
reader::ns_reader::read_to_end::start
reader::ns_reader::read_to_end_into::start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to check that the changes does not break anything else when
read_to_endwould be called after each possible returned events, but now I'm too lazy to finish the tests. Will do that on weekend.