refactor(cli): dedup deploy ownership tracking#1646
Merged
Conversation
…ce helpers Replace inline isOwnedByApp(...) checks and the conflict/unmanaged/owner-set branching in auth, idp, resolver, function-registry, tailordb, secret-manager, and auth-connection deploy planners with the shared trackDesiredResourceOwnership / trackRemainingResourceOwner helpers, matching the pattern already used in executor, workflow, staticwebsite, and aigateway. No behavior change. Claude-Session: https://claude.ai/code/session_01NLYAfzKJnUxB5d2L1dpiCH
🦋 Changeset detectedLatest commit: d1a12e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This comment has been minimized.
This comment has been minimized.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📖 Docs Quality & Consistency Check
✅ Docs are consistent with the implementation and contain no user-facing internal-detail leaks.
Checked areas:
- Deployment ownership tracking behavior documented in
packages/sdk/docs/cli/application.mdlines 77, 138-145 (stable app ID tracking, conflicts, unmanaged resources) - Secret Manager vault ownership behavior documented in
packages/sdk/docs/services/secret.mdlines 176-179 - GitHub Actions application ownership behavior documented in
packages/sdk/docs/github-actions.mdlines 203-204 - Changeset description accuracy (patch level, user-facing description)
Summary:
This PR is a pure internal refactoring that extracts repeated ownership-checking logic into two helper functions (trackDesiredResourceOwnership and trackRemainingResourceOwner). The refactored code maintains identical behavior to the original inline implementations:
- Same ownership classification logic
- Same conflict/unmanaged resource tracking
- Same JSON output format for
--dry-run --json - No changes to user-facing CLI commands, options, or APIs
All existing documentation about deployment ownership tracking, conflict detection, and unmanaged resource handling remains accurate because the behavior is unchanged.
Re-run this check by adding the
docs-checklabel to the PR.
…-ownership # Conflicts: # packages/sdk/src/cli/commands/deploy/auth.ts # packages/sdk/src/cli/commands/deploy/idp.ts
Code Metrics Report (packages/sdk)
Details | | main (6851982) | #1646 (5c85491) | +/- |
|--------------------|----------------|-----------------|-------|
- | Coverage | 72.4% | 72.4% | -0.1% |
| Files | 432 | 432 | 0 |
| Lines | 16370 | 16321 | -49 |
- | Covered | 11857 | 11817 | -40 |
+ | Code to Test Ratio | 1:0.4 | 1:0.4 | +0.0 |
| Code | 108107 | 108105 | -2 |
| Test | 47296 | 47296 | 0 |Code coverage of files in pull request scope (80.4% → 80.4%)
SDK Configure Bundle Size
Runtime Performance
Type Performance (instantiations)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deploy planning keeps ownership handling consistent across resource types without changing behavior.