chore: packages update#23
Open
iordanGrancharov wants to merge 2 commits into
Open
Conversation
PekoPPT
reviewed
Dec 22, 2023
PekoPPT
left a comment
PekoPPT
left a comment
There was a problem hiding this comment.
We have to include a package-lock.json file with pre-defined versions of the components to be able to pass the build. Check the error here for more info: https://github.com/telerik/react-coffee-warehouse/actions/runs/7277313292/job/19829038754?pr=23
iordanGrancharov
force-pushed
the
packages-update
branch
from
9dcb185 to
d698c10
Compare
PekoPPT
approved these changes
Dec 22, 2023
PekoPPT
left a comment
PekoPPT
left a comment
There was a problem hiding this comment.
The app works OK and no warnings appear. The only thing I noticed is the following that appears in the the console, when the app is started locally:
When navigating to http://localhost:3000/react-coffee-warehouse the console warns the following:
As the app si automatically deployed this URL could be there on purpose but you can discuss it with @kspeyanski
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
Related items