Shorten deployment names when over 47 characters#204
Open
Conversation
carlydf
commented
Feb 25, 2026
|
|
||
| // ComputeVersionedDeploymentName generates a name for a versioned deployment | ||
| // Name will be <=47 characters and unique for that Worker Deployment Version within the namespace. | ||
| func ComputeVersionedDeploymentName(baseName, buildID string) string { |
Collaborator
Author
There was a problem hiding this comment.
see kubebuilder library for shortening k8s resource names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Shorten deployment names (while keeping them unique) if over 47 characters.
Why?
Deployment names in k8s should be <=47 characters so that Pod names can be short enough for DNS limits.
Checklist
Closes
How was this tested:
New unit tests, and existing functional tests. Ideally we should upgrade test this to ensure that controller can still find deployments that have names in the old format, and ensure that the controller doesn't try to recreate Deployments with different names. From reading the code I believe this should all work.
Any docs updates needed?