feat: use dialog for add token button

[farolanf]

Fix #42

[temptemp3]

These move the message down so that there is not a jump in the ui when it appears and disappears.

Maybe what we can do is not have a error message every time an asset is not found.

• Update asset not found error message to be a less jump ux

[temptemp3]

• Update add confirmation for vsa
  I am thinking we would need to show some asset info and the confirmation should say "Opt in to {ASSETNAME} (VSA:{ASSETID})

[temptemp3]

Unable to add asset. After clicking add button nothing happens but there is a failed request.

Asset id: 1290865

[temptemp3]

• Adding arc200 might require some fixing as well
  ARC200:6795477 TacoCoin

[temptemp3]

Request changes. Thx!

[farolanf]

Maybe what we can do is not have a error message every time an asset is not found

How about this? (No UI jumps)

Or should we remove the error message?

[temptemp3]

Okay that is better 2023年12月22日(金) 2:45 Farolan Faisal ***@***.***>:

…

Maybe what we can do is not have a error message every time an asset is not found How about this? (No UI jumps) Screenshot.2023-12-22.174013.png (view on web) <https://github.com/temptemp3/arc-200/assets/15892844/02f175d2-d40e-48b2-8f1e-34f85fac5e03> Or should we remove the error message? — Reply to this email directly, view it on GitHub <#73 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFQ4AW7PDVBAWQ6GEHOICDLYKVJDBAVCNFSM6AAAAABA7CCGOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRXGQ3DQNRQGE> . You are receiving this because you commented.Message ID: ***@***.***>

[farolanf]

When adding the asset by invoking acc.tokenAccept(tokenId) the WalletConnect QRCode modal pops up which is different with the wallet I use to sign in(WalletConnectModalSign).

With the WalletConnect QRCode I'm unable to sign in

It works with WalletConnectModalSign

I think it should use whatever wallet provider the user used to sign in, but I haven't found a way to do it. Any directions?

[temptemp3]

When adding the asset by invoking acc.tokenAccept(tokenId) the WalletConnect QRCode modal pops up which is different with the wallet I use to sign in(WalletConnectModalSign).

With the WalletConnect QRCode I'm unable to sign in

It works with WalletConnectModalSign

I think it should use whatever wallet provider the user used to sign in, but I haven't found a way to do it. Any directions?

I would look at components/SwapForm it has support for a custom wallet (kibisis) and defly (A-wallet)

[temptemp3]

I would also pull in changes from main. It has a web3 modal that looks like it is for A-wallet.

[farolanf]

Demo

demo.mp4

[temptemp3]

Thanks, I'll check it out! 2024年1月10日(水) 2:26 Farolan Faisal ***@***.***>:

…

Demo https://github.com/temptemp3/arc-200/assets/15892844/91439f94-ff38-4f3b-8d2f-b0beac3b2928 — Reply to this email directly, view it on GitHub <#73 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFQ4AWYVVTCPLQM5QHWPCL3YNZNF7AVCNFSM6AAAAABA7CCGOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBUGQ3TQOBTGU> . You are receiving this because you commented.Message ID: ***@***.***>

[temptemp3]

Demo

demo.mp4

Could you make a demo for voitest adding an arc200?

[farolanf]

Tried adding asset with Kibisis on Voi Testnet but got error:

OperationCanceledError: no response from wallet for "message.enable_request"

[temptemp3]

Okay. Do you know which version? 2024年1月15日(月) 18:50 Farolan Faisal ***@***.***>:

…

Tried with Kibisis on Voi Testnet but got error: OperationCanceledError: no response from wallet for "message.enable_request" — Reply to this email directly, view it on GitHub <#73 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFQ4AW6VKVOJ3OBGHTTUGFLYOXMHDAVCNFSM6AAAAABA7CCGOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSHE2TKNRUGU> . You are receiving this because you commented.Message ID: ***@***.***>

[farolanf]

Kibisis 1.9.0

Also tried after merging with feature/swap, same results.

[temptemp3]

Ok, I'll check it out. 2024年1月15日(月) 19:26 Farolan Faisal ***@***.***>:

…

Kibisis 1.9.0 Also tried after merging with *feature/swap*, same results. — Reply to this email directly, view it on GitHub <#73 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFQ4AW3YSOHKWWGH7YARRWTYOXQOJAVCNFSM6AAAAABA7CCGOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSHE3TQNZVGY> . You are receiving this because you commented.Message ID: ***@***.***>