docs(packager): correct CoralPay/Zone provenance comments to clean-room#19
Open
canaan5 wants to merge 1 commit into
Open
docs(packager): correct CoralPay/Zone provenance comments to clean-room#19canaan5 wants to merge 1 commit into
canaan5 wants to merge 1 commit into
Conversation
The CoralPay and Zone doc comments still claimed the profiles were "generated field-for-field from the certified jPOS GenericPackager definition" — the exact derivation phrasing flagged under roadmap B4 and already corrected in the CHANGELOG and release notes. Bring the source comments in line: clean-room layouts composed from public ISO 8583:1987 field semantics and the acquirers' published field tables. Comment-only; no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CoralPayandZoneGo doc comments still literally claimed the profiles were "generated field-for-field from the certified jPOS GenericPackager definition (fields2.xml / zone.xml)" — the exact derivation phrasing flagged under roadmap B4, which was already corrected everywhere else (CHANGELOG[0.3.0], and thev0.3.0/v1.0.0-rc.1GitHub release notes). These two source comments were missed.Brings them in line with the established clean-room wording: layouts composed from public ISO 8583:1987 field semantics and the acquirers' published field tables.
Comment-only; no behavior change.
gofmt/go vet/go build ./packager/clean. Closes the last source-level instance of the B4 provenance-claim phrasing (the remaining hit inROADMAP-to-v1.mdis the roadmap describing the problem, which is correct context).