feat: forward all render options through renderHook#83
Open
greymoth-jp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renderHookonly pullswrapperout of its options and passes{ wrapper }on torender, so the rest of the render options (container,baseElement,queries) get silently dropped. For examplerenderHook(cb, { container })has no effect — the hook still mounts into a freshly created container underdocument.body.@testing-library/reactstarted out with the same shape and changed it in testing-library/react-testing-library#1118 to spread the remaining options straight through:This does the same thing here, so
renderHookaccepts the same render options asrender.I added a test that passes a custom
containerand checks the wrapper actually renders into it — without the change it fails (the marker ends up in the auto-created container instead). The rest of the suite stays green (105 tests).Kept this to the runtime only and left the
RenderHookOptionstype alone, since #82 is already touching it.