Misc c++17 and other stuff

examples/scalable_login_screen/ScalableLoginScreen.cpp

@@ -51,7 +51,7 @@ void loadWidgets(tgui::BackendGui& gui)
     gui.onViewChange([&gui] { updateTextSize(gui); });
 
     // Create the background image
-    // The picture is of type tgui::Picture::Ptr which is actually just a typedef for std::shared_widget<tgui::Picture>
+    // The picture is of type tgui::Picture::Ptr which is just a type alias declaration for std::shared_ptr<tgui::Picture>
     // The picture will fit the entire window and will scale with it
     auto picture = tgui::Picture::create("xubuntu_bg_aluminium.jpg");
     picture->setSize({"100%", "100%"});

include/TGUI/String.hpp

@@ -522,11 +522,7 @@ namespace tgui
 
         [[nodiscard]] char32_t* data() noexcept
         {
-#if __cplusplus >= 201703L
             return m_string.data();
-#else
-            return &m_string[0];
-#endif
         }
 
         [[nodiscard]] const char32_t* c_str() const noexcept

include/TGUI/Variant.hpp

@@ -35,7 +35,7 @@ namespace tgui
 {
     ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
     /// @internal
-    /// @brief Wrapper around std::variant
+    /// @brief Deprecated wrapper around std::variant
     ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
     template <typename... Types>
     class TGUI_DEPRECATED("Use std::variant instead") Variant

src/Signal.cpp

@@ -158,7 +158,7 @@ namespace tgui
         assert(!paths.empty());
         const String& pathStr = paths[0].asString();
         m_parameters[1] = static_cast<const void*>(&pathStr);
-        m_parameters[2] = static_cast<const void*>(&paths[0]);
+        m_parameters[2] = static_cast<const void*>(paths.data());
         m_parameters[3] = static_cast<const void*>(&paths);
         return Signal::emit(widget);
     }