Some small stuff#368
Conversation
Inline variables are a mandatory core language feature in C++17, so there's no longer a need to check, we can assume it's available.
|
I'm a bit torn about the "Remove some redundant access specifiers" commit. While it's technically correct, I've always preferred to separate functions and members and I've abused the access specifiers a bit to be the title for each group (due to it being on a different indentation). Ignoring "protected" for simplicity here, you would have 4 groups inside a class:
Each group would start with an access specifier. Since public variables often doesn't exist, it did lead to "private" being repeated for the functions and variables section. So while I'm not heavily against the change, I still have a preference for the duplicate access specifier as small extra indication that you switch from functions to variables. |
|
I don't feel strongly about it. It's just something I've never done myself and I noticed it, so I cleaned it up. |
|
Then at least for now it would be best if you just dropped that commit. |
|
I'll drop it and update the PR tomorrow. 🙂 |
…row_move_constructible_v<>
2 participants
No description provided.