Assert valkey service on EL10 in redis acceptance test - #412
Merged
Conversation
RHEL/CentOS Stream 10 dropped Redis in favor of Valkey; puppet-redis already handles this correctly by installing Package[valkey]/ Service[valkey] there instead of Package[redis]/Service[redis]. The acceptance test hardcoded 'redis' as the service name, which fails on EL10 even though the underlying install works. Ref: theforeman/el10_rebuild#25
Member
Author
|
Breaking this into another PR, so we can merge it for us to release with forklift and have the rpms published. The valkey test worked at #411 |
ekohl
approved these changes
Aug 3, 2026
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
puppet-redisalready handles this correctly on EL10 by installingPackage[valkey]/Service[valkey]instead ofPackage[redis]/Service[redis].spec/acceptance/basic_spec.rbhardcoded the service nameredis, which fails on EL10 even though the underlying install works correctly.valkeyon RedHat-family OSes release >= 10,redisotherwise.Split out from #411 so this fix can land independently of the temporary EL10 CI job in that PR.
Test plan
service('redis')unchangedservice('valkey')and pass