⏱️ Increase interval test timeout for CI reliability#1144
Closed
Conversation
In Windows CI, we don't reliably get 10 intervals in 50ms. Raise the timeout to half a second. This won't add time to the test because it passes as soon as 10 intervals are observed.
Member
Author
|
bundled with #1145 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In CI environments (especially Windows), 50ms is not enough time to reliably produce 10 intervals. The test flakes because the timeout fires before the intervals are observed.
Approach
Increase the interval test timeout from 50ms to 500ms. This has no impact on test duration since the
raceresolves as soon as 10 intervals are observed — the timeout only fires if something is actually broken.