✨ add allSettled() operation congruent with Promise.allSettled()#1158
Open
rauhryan wants to merge 2 commits intothefrontside:v4from
Open
✨ add allSettled() operation congruent with Promise.allSettled()#1158rauhryan wants to merge 2 commits intothefrontside:v4from
rauhryan wants to merge 2 commits intothefrontside:v4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses #898 — Effection has
all()andrace()matchingPromise.all()andPromise.race(), but lacks an equivalent ofPromise.allSettled().Approach
Adds a new
allSettled()operation that runs all given operations concurrently and waits for every one to settle. Unlikeall(), it never short-circuits on error — each result is represented as Effection'sResult<T>shape ({ ok: true, value }or{ ok: false, error }).Key decisions:
Result<T>rather thanPromiseSettledResult<T>so settled outcomes compose consistently with the rest of the libraryallSettled()by composing existing primitives:all()overbox()-wrapped operationsResult,Ok, andErras public API sinceallSettled()now exposesResult<T>directlyFiles changed
lib/all-settled.ts—allSettled()implementation andAllSettledmapped type usingResult<T>lib/result.ts— public API docs forResult,Ok, andErrtest/all-settled.test.ts— coverage for success, failure, teardown, and type inference usingResult<T>docs/async-rosetta-stone.mdxanddocs/spawn.mdx— updated prose for theResult<T>shape and linked result helpersAGENTS.md— updated guidance forallSettled()semanticsTest coverage
[]{ ok: true, value }{ ok: false, error }without throwingResult<T>-based tuple shape