Refine figure embed URL handling and fix regression for http(s) figure images - #1290
Open
cbutcosk wants to merge 9 commits into
Open
Refine figure embed URL handling and fix regression for http(s) figure images#1290cbutcosk wants to merge 9 commits into
cbutcosk wants to merge 9 commits into
Conversation
cbutcosk
changed the base branch from
main
to
fix/figures-media-video-audio-posters
August 31, 2026 13:28
cbutcosk
marked this pull request as ready for review
August 31, 2026 15:21
This was
linked to
issues
Sep 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the figures plugin to normalize URL calculations for embed figures (youtube, vimeo, soundcloud) and fix a regression in http(s) figures (see #1289). It is the final part of #1197 . Details:
figureMediaobject and are properly formatted.FigureMediaprocessing loop, insertingembedUrlandsourceUrlonderivatives.embed. RefactorsfigureMediaEmbedUrlcomponent to be a helper function of the figures plugin.FigureMediathat fetches http(s) URLs for use in dimensions calculation. Removes component-side figure embed calculation.