Fix: Skip Next and Continue Lesson button#2664
Open
Anindra123 wants to merge 1 commit into4.0.0-devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
$this->get_course_contents_by_id( $course_id );was getting all the content based on topic id and grouping it based on the menu_order, thus if two topic have menu order 1,2,3,4,5, the order the content were coming in was like 1,1,2,2,3,3,4,4...etc. Therefore when clickSkip AssignmentorContinue lessonit was going to the next topic assignment or quiz. To fix this instead of getting all the content and grouping, i had looped over the individual topics course content since it is sorted and added those course content in the sorted order defined in the topic