Added backend validation for student activities in course#2676
Open
Anindra123 wants to merge 6 commits into4.0.0-devfrom
Open
Added backend validation for student activities in course#2676Anindra123 wants to merge 6 commits into4.0.0-devfrom
Anindra123 wants to merge 6 commits into4.0.0-devfrom
Conversation
shewa12
reviewed
May 8, 2026
| $can_enroll = $this->validate_course_enrollment_period( $course_id ); | ||
| if ( ! $can_enroll ) { | ||
| $referer_url = wp_get_referer(); | ||
| wp_safe_redirect( tutor_utils()->get_nocache_url( $referer_url ) ); |
Collaborator
There was a problem hiding this comment.
What if the wp_get_referer() returns false?
shewa12
reviewed
May 8, 2026
| * | ||
| * @return bool | ||
| */ | ||
| public function validate_course_enrollment_period( $course_id ) { |
Collaborator
There was a problem hiding this comment.
Use the typehint (int) & validate the $course_id
shewa12
reviewed
May 8, 2026
| * | ||
| * @return bool | ||
| */ | ||
| public function validate_course_enrollment_period( $course_id ) { |
Collaborator
There was a problem hiding this comment.
The method name should be changed. We are restricting enrollment based on the period clause. The method name should reflect the implementation.
sazedul-haque
requested changes
May 8, 2026
| } | ||
| } else { | ||
| tutor_toast(__('Error', 'tutor-pro'), data?.data?.message ?? 'Something went wrong!!', 'error'); | ||
| if ( data.data.message ) { |
Collaborator
There was a problem hiding this comment.
Update this like if ( data?.data?.message ) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.