Enrich logo of entities from system owned subprocessors#2377
Conversation
github-actions
Bot
added
enhancement
|
| defaultPredicates = append(defaultPredicates, subprocessor.NameEqualFold(name)) | ||
| } | ||
|
|
||
| processors, err := m.Client().Subprocessor.Query(). |
There was a problem hiding this comment.
you'd presumably need to do a privacy bypass here?
There was a problem hiding this comment.
They are system-owned subprocessor, not privacy bypass needed, user would have access to these. They work the same way with trust-center subprocessors being able to be created based on these
| if description, ok := m.Description(); !ok || strings.TrimSpace(description) == "" { | ||
| if strings.TrimSpace(processors.Description) != "" { | ||
| m.SetDescription(processors.Description) | ||
| } |
There was a problem hiding this comment.
why would we ever want to trim spaces on a description?
| var names []string | ||
|
|
||
| fn := func(name string) { | ||
| name = strings.TrimSpace(name) |
There was a problem hiding this comment.
should not be trimming spaces on a name that could be 2 words
| assert.NilError(t, err) | ||
| assert.Assert(t, resp != nil) | ||
|
|
||
| assert.Check(t, is.Equal(description, *resp.CreateEntity.Entity.Description)) |
There was a problem hiding this comment.
confused how this test would pass given the description definition above has spaces in it and the hook would have trimmed them out in the created entity
3 participants
No description provided.