Open
Conversation
Contributor
|
The function already has 5 parameters which is already too many. Is there a way to solve this without adding a 6th? |
Author
|
I attempted to remove |
Contributor
|
There's already an options array. Could this feature be one of the keys on the options array? |
Author
|
The problem lies with the object casting. It converts $array = array(
'members_to_add' => array(
'test@example.com'
)
);into |
Contributor
|
Actually, we'd want the opposite so it doesn't change the existing behavior |
Author
|
Ok, I believe this is ready to be reviewed. I have another PR ready for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow users to use Views Bulk Operations to add subscribed members to an already-created static segment.
A subsequent mailchimp.module patch for adding users will appear on drupal.org.