Skip to content

Conversation

@d0ubIeU
Copy link
Contributor

@d0ubIeU d0ubIeU commented Jan 13, 2026

fix: duplicate instruction removed

Summary by CodeRabbit

  • Bug Fixes
    • Fixed redundant processing in statistics search functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

fix: duplicate instruction removed
@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

📝 Walkthrough

Walkthrough

Removed a duplicate registration of the LanguageCodeTwigExtension Twig extension in the StatisticsSearchController. The extension was being added twice consecutively; the second redundant call has been eliminated, leaving only the initial registration.

Changes

Cohort / File(s) Change Summary
Twig Extension Deduplication
phpmyfaq/src/phpMyFAQ/Controller/Administration/StatisticsSearchController.php
Removed duplicate addExtension(new LanguageCodeTwigExtension()) call; extension is now registered only once instead of twice

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • PR #3860: Both PRs interact with the LanguageCodeTwigExtension registration in StatisticsSearchController—this PR removes a duplicate registration that may have been introduced alongside the initial extension addition.

Poem

🐰 A bundle so clean, with no double bind,
One registration where once were two aligned,
The extension hops in with grace pristine,
No wasteful whispers of code in between! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update StatisticsSearchController.php' is vague and generic, using non-descriptive language that doesn't convey the specific change being made. Use a more descriptive title that reflects the actual change, such as 'Remove duplicate LanguageCodeTwigExtension registration in StatisticsSearchController'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c36fb90 and 5abacf4.

📒 Files selected for processing (1)
  • phpmyfaq/src/phpMyFAQ/Controller/Administration/StatisticsSearchController.php
💤 Files with no reviewable changes (1)
  • phpmyfaq/src/phpMyFAQ/Controller/Administration/StatisticsSearchController.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: phpMyFAQ 8.6 Test on ubuntu-latest
  • GitHub Check: phpMyFAQ 8.4 Test on ubuntu-latest
  • GitHub Check: phpMyFAQ 8.5 Test on ubuntu-latest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thorsten thorsten merged commit 380ef05 into thorsten:main Jan 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants