Zip and attach the Quickstart sample to GitHub releases - #19
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe release workflow now exposes the bumped version and adds a dependent job that packages the tagged Quickstart sample with the released SDK version and uploads the ZIP archive to the GitHub release. ChangesQuickstart release packaging
Estimated code review effort: 3 (Moderate) | ~15–30 minutes Mergeability Score: ⚪ Minimal · up to This PR adds release packaging for the Quickstart sample without any identified merge-blocking risk; it is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant Release as release job
participant Package as package-quickstart job
participant GitHub as GitHub release
Release->>Package: Pass bumped version
Package->>Package: Check out release tag
Package->>Package: Update SDK dependency
Package->>Package: Reject symbolic links
Package->>GitHub: Upload versioned ZIP archive
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds a package-quickstart job to the release workflow that extracts samples/quickstart from the tagged commit, repoints its pubspec.yaml path dependency from the local monorepo source to the published version on pub.dev, zips it, and uploads it as a release asset. The tag checkout sets persist-credentials: false and the job rejects any symlinks in the extracted sample before zipping it, to prevent credential exfiltration through the release archive. Signed-off-by: Brion <info@brionmario.com>
b17021d to
6cc24a6
Compare
Purpose
Publish the Quickstart sample as a standalone, downloadable zip on each GitHub release, so it can be grabbed without cloning the whole SDK monorepo.
Approach
Adds a
package-quickstartjob torelease.ymlthat runs afterreleasesucceeds:samples/quickstartviagit archive.pubspec.yaml'sthunderid_flutter: path: ../..tothunderid_flutter: ^<version>so the zipped copy resolves the SDK from pub.dev instead of a relative path into the monorepo.gh release upload.Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks
Summary by CodeRabbit