Refactor(message-list): implement LocalMessageUidPrefixProvider#10891
Refactor(message-list): implement LocalMessageUidPrefixProvider#10891mohitsatr wants to merge 1 commit into
Conversation
|
Missing report label. Set exactly one of: |
|
@rafaeltonholo, Should |
mohitsatr
force-pushed
the
localmessageuidprefixprovider
branch
from
9d2fb8d to
d9bfd74
Compare
|
Missing report label. Set exactly one of: |
Yes, that is it! |
rafaeltonholo
added
report: exclude
mohitsatr
changed the title
rafaeltonholo
left a comment
rafaeltonholo
left a comment
There was a problem hiding this comment.
Hi @mohitsatr, thanks for this contribution! We need to fix some issues before merging this.
Please see that the quality and test CI have failed. To address the Spotless, often running ./gradlew spotlessApply will auto-fix the issues.
| assertThat(deleted).isEqualTo(0) | ||
| assertThat(folderId).isEqualTo(1) | ||
| assertThat(uid).isNotNull().startsWith(K9.LOCAL_UID_PREFIX) | ||
| assertThat(uid).isNotNull().startsWith("") |
There was a problem hiding this comment.
| assertThat(uid).isNotNull().startsWith("") | |
| assertThat(uid).isNotNull().startsWith(localMessageUidPrefixProvider.get()) |
| private final LocalMessageUidPrefixProvider localMessageUidPrefixProvider = | ||
| DI.get(LocalMessageUidPrefixProvider.class); |
There was a problem hiding this comment.
This should be injected via the constructor.
2 participants
Closes #10511