tests: add edge-case tests for str_remove() and str_remove_all()#608
Closed
LeonidasZhak wants to merge 1 commit into
Closed
tests: add edge-case tests for str_remove() and str_remove_all()#608LeonidasZhak wants to merge 1 commit into
LeonidasZhak wants to merge 1 commit into
Conversation
Add tests for NA propagation, empty strings, zero-length input, factor coercion, and no-match behavior. These data-cleaning edge cases had no coverage despite str_remove/str_remove_all being commonly used in cleaning workflows.
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds edge-case test coverage for
str_remove()andstr_remove_all():NAvalues (single and mixed with non-NA)character()input returnscharacter()Motivation
str_remove()andstr_remove_all()are thin wrappers aroundstr_replace()/str_replace_all(), but the test file (9 lines) had zero coverage for these common data-cleaning edge cases. The DESCRIPTION claims all functions deal with NAs and zero-length vectors consistently — these tests verify that claim for the remove family.Tests run
All 15 remove tests pass (5 new test blocks, 13 new assertions). Full suite has 2 pre-existing snapshot failures (lifecycle wording changes), unrelated to this work.