Feat/leveled npc sync v2

[absol89]

Fixes #639 and puts the base form and approximate max HP near equal on all clients in the cell. Leading to less combat desync. Reviewer note: These files are touched by naked NPC fixes as well, and can additively merge.

PR: feat/leveled-npc-sync-v2 vs upstream/dev

Branch: absol89/TiltedEvolutionScriptFixes@feat/leveled-npc-sync-v2 → tiltedphoques/TiltedEvolution@dev
Merge base: 9d81ef07 (current upstream/dev HEAD, so the branch is rebased on upstream dev)
Scope: 16 files changed, +325 / −19

Goal

Make every client render the same leveled-NPC identity that the actor's owner rolled, instead of each client independently rolling its own pick from the leveled list. Without this, two players standing near the same leveled bandit see different NPCs (different faces/races/equipment), and ownership transfers can leave remote clients stuck on the wrong pick.

How it works

The owner captures the resolved pick at assignment time and the server stores/relays it. Every other client conforms its locally-rolled actor to the owner's pick by swapping the base form (disable → re-enable 3D → swap base).

Wire protocol — new LeveledNpcPickId field

Added to four messages (client ↔ server):

• AssignCharacterRequest (.h/.cpp)
• AssignCharacterResponse (.h/.cpp)
• CharacterSpawnRequest (.h/.cpp)
• NotifySpawnData (.h/.cpp)

Each gets the new GameId LeveledNpcPickId{} field plus serialize/deserialize and operator== updates.

Server side (Code/server/)

• CharacterComponent.h: new FormIdComponent LeveledNpcPickId{} stored on the character.
• CharacterService.cpp:
  • CreateCharacter: stores message.LeveledNpcPickId as received (client-authoritative, same trust model as BaseId).
  • Serialize (spawn): copies the stored pick into CharacterSpawnRequest::LeveledNpcPickId.
  • OnAssignCharacterRequest: on ownership transfer within a party, the new owner's pick becomes authoritative (LeveledNpcPickId = message.LeveledNpcPickId); the assignment response relays the stored pick back to the requesting client.
  • BroadcastActorData: includes the pick in NotifySpawnData (ownership transfers / updates).

Client side — capture (Code/client/)

• TESNPC.cpp / TESNPC.h:
  • Hook SetLeveledNpc (fn 14375) is enabled. It records (tempBaseFormId → pickedNpcFormId) in a mutex-guarded s_leveledPicks map for recovery.
  • TESNPC::GetLeveledPickFormId() reads that map (last resort).
  • TESNPC::GetLeveledPick() walks the template chain and returns the first static NPC — the robust path, since the chain can't go stale. Guarded by formType checks because chain entries may be TESLevCharacter masquerading as TESNPC*.
• CharacterService.cpp RequestServerAssignment: when the base is temporary, prefer GetLeveledPick() (chain) and only fall back to the resolver map for named leveled NPCs (whose chain hides the pick). The captured pick is sent as message.LeveledNpcPickId and the actor is assigned via its template base.

Client side — apply / conform

• CharacterService.cpp:
  • OnCharacterSpawn / CreateCharacterForEntity: prefer LeveledNpcPickId over the lossy template BaseId when spawning a remote actor.
  • OnAssignCharacter / OnRemoteSpawnDataReceived: call ApplyLeveledNpcPick(...) so assignment responses and ownership transfers conform the local actor to the owner's pick.
  • ApplyLeveledNpcPick: skips non-shell static bases (already-conformed actors); only conforms actors whose base is an unresolved leveled shell (IsUnresolvedLeveledShell — a static base still templating onto a LeveledCharacter list) or a temporary base whose pick differs from the owner's. It never mutates the reference directly (avoids re-locking the drained-task mutex) — it queues a LeveledConformData entry in m_pendingLeveledConforms.
  • ProcessLeveledConforms (runs on the service update tick):
    • Skips while the Loading Menu is open (cell attach owns references mid-stream).
    • Distant actors whose 3D hasn't loaded stay pending (shell actors exempt).
    • On apply: DisableImpl() then set Disabled=true; next tick rebuilds the 3D with baseForm = pick via EnableImpl(), and zeroes GraphDescriptorHash so the animation-graph descriptor is recomputed — this prevents the OOB variable-index crash when a pick crosses animation projects (e.g. rabbit → fox).
    • m_pendingLeveledConforms is cleared on disconnect.

Other fixes bundled in

• TESObjectREFR.cpp (SaveAnimationVariables / LoadAnimationVariables): bounds-checks the variable-set index against pVariableSet->size for booleans/floats/integers — prevents OOB reads/writes during animation variable serialization (a crash fix independent of the leveled feature but needed for stable conform).
• .gitignore: ignores local tooling (vsxmake2026, .claude/, CLAUDE.md, docs/superpowers/) — local-only, not gameplay-relevant.

Risk notes

• The resolver map (s_leveledPicks) is keyed by recycled temp form ids and is bypassed by some spawn paths (live cell attach). It is used strictly as a last resort; the template chain is authoritative. A map hit may describe a previous occupant of the id — acceptable because chain-derived picks win.
• LeveledNpcPickId is client-authoritative on the server (same as BaseId); a forged id can at worst change which NPC identity renders. No trust/safety boundary crossed.
• Conform touches the 3D only on the service tick with the loading screen guard, so no loader re-entrancy crash.

Testing hooks

Each capture/apply/conform step logs via spdlog (most demoted to debug in the final commit, 4fb53dde "leveled NPC resolution probe" and 200c5d41 "demote logging" removed the temporary probe / quieted routine logs). Watch for:

• Captured leveled NPC pick ... for actor ...
• Conforming leveled actor ... to owner's pick ...
• Re-enabled conformed leveled actor ...