syscalls: dereferencing syscall argument pointers, parsers for argument values (modified pr #1824) #1852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified idea from #1824 by @1ndahous3, so most of that pr is included, with some changes.
fill_fmt_args uses parsers specified by:
Subkeys from #1850 are used to have a
"Arguments"and"Extra"subkeys. Parsers can modify output argument values or add data to"Extra"subkey.There are 2 boolean options:
--syscall-nested-args- controls if arguments are nested in an"Arguments"subkey--syscall-dereference-args- controls if argument pointers are dereferenced and enables extra parsers (the goal was for the default setting to leave only parsers corresponding to previous parse_argument and win_extract_string functions, its up to each parser to respect that)With both of these flags disabled output format should be backwards compatible
New parsers allow for reading:
This pr is based on #1850 and also #1851 (though this one is not strictly necessary)