Switch to tc-prod private repo by default#15
Open
Part-TimeWizard wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of tcl-4461
Note
Low Risk
Low risk: changes are limited to a local build/push helper script, but could misdirect image pushes if the ECR repo/region is incorrect.
Overview
tag_build_and_push.shnow targets the tc-prod private ECR (651706779278.dkr.ecr.us-west-2.amazonaws.com) formake image/make docker-pushinstead of the public ECR repo.The script no longer auto-runs AWS/ECR login; if the user answers they are not logged in, it prints the required
aws sso login/aws ecr get-login-passwordcommands and exits. It also clarifies how to override the image tag viaTAG=....Written by Cursor Bugbot for commit 049c710. This will update automatically on new commits. Configure here.