use cluster-name label to broad nodeselector of watcher#16
Merged
syutogether merged 1 commit intoMay 11, 2026
Merged
Conversation
Coverage Report for CI Build 25623840412Warning No base build found for commit Coverage: 56.119%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Part-TimeWizard
approved these changes
May 11, 2026
| // covers both KubeVirt virt-launcher pods (via CAPK) and Virtink VM pods (via CAPCH). | ||
| // CAPI propagates this label onto every machine-owned pod regardless of provider. | ||
| var capiClusterNameSelector = func() string { | ||
| req, err := labels.NewRequirement("cluster.x-k8s.io/cluster-name", selection.Exists, nil) |
There was a problem hiding this comment.
Super tiny nit: I think the reason I did the mustValidate and panic was to fail early if the label was malformed. If this provides the same protection or you think it's unnecessary, feel free to ignore
Author
There was a problem hiding this comment.
Yes, it validates the key format too. And panic if it's malformed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.