support qcow2 overlay for vm with persistance#6
Open
adamsch1 wants to merge 6 commits into
Open
Conversation
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 7
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an idea
Note
Introduces a new overlay volume type enabling qcow2 copy-on-write disks with PVC/HostPath backing and optional persistent targets, with full validation, rendering, conversion, creation, and cleanup paths.
v1.OverlayVolumeSourcetoVolumeSourcewith backing (backingPVC/backingHostPath), target (targetPVC/targetHostPath),backingFormat, andpersistent.persistentrules, PVC/HostPath fields, andbackingFormat(raw|qcow2).backing-<vol>and optionaltarget-<vol>via PVC or HostPath.qcow2source and properbackingStore(file/block, format).overlay-disk-handlerto create overlay images and cleanup non-persistent overlays; tests added.CreateBackedImageForVolume.OVERLAY_VOLUMES.mdandOVERLAY_VOLUME_STATES.mdwith usage and state matrix.Written by Cursor Bugbot for commit d75455f. This will update automatically on new commits. Configure here.