Conversation
What was broken Challenges tied to projects could still be activated when the linked billing account was inactive, expired, or had no remaining budget. Root cause Activation validation only checked whether a project billing account id existed. It did not verify billing-account lifecycle state or remaining funds against the billing account data. What was changed Added billing-account detail lookup support in the project helper, including normalized active, end-date, status, and remaining-budget fields. Updated challenge activation validation to block project-backed launches when the billing account is missing, inactive, expired, not found, or has no remaining funds. Wired the billing account validation into challenge status updates while preserving the existing project billing-account persistence flow. Any added/updated tests Added focused unit coverage for the new activation billing-account validation paths. Updated challenge service tests to cover inactive, expired, insufficient-funds, and valid billing-account activation scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Challenges tied to projects could still be activated when the linked billing account was inactive, expired, or had no remaining budget.
Root cause
Activation validation only checked whether a project billing account id existed. It did not verify billing-account lifecycle state or remaining funds against the billing account data.
What was changed
Added billing-account detail lookup support in the project helper, including normalized active, end-date, status, and remaining-budget fields.
Updated challenge activation validation to block project-backed launches when the billing account is missing, inactive, expired, not found, or has no remaining funds.
Wired the billing account validation into challenge status updates while preserving the existing project billing-account persistence flow.
Any added/updated tests
Added focused unit coverage for the new activation billing-account validation paths.
Updated challenge service tests to cover inactive, expired, insufficient-funds, and valid billing-account activation scenarios.
Validation notes:
pnpm lintpassed.pnpm buildcould not run because this repo has nobuildscript.pnpm teststill fails in pre-existingTimelineTemplateServicetests unrelated to this change, while the focused billing-account unit tests pass.